Re: linux-2.2.13pre9: conflicting defines for DEBUG (irda problem)

Dag Brattli (dagb@cs.uit.no)
30 Nov 1999 07:45:28 +0100


"Adam J. Richter" <adam@yggdrasil.com> writes:

> linux-2.2.13pre9/include/net/irda/irda.h defines a macro
> named DEBUG, and the drivers/net/sk98lin/skge.c indirectly includes
> this file when it pulls in some general networking-related .h files.
> Unfortunately, a number of files in the sk98lin subdirectory use
> DEBUG as a flag that enables debugging and indicates that a number
> of other #defines have been made. Of course, these other defines
> were not made, so the compile bombs out.
>
> I believe the correct fix is for irda to use a different
> macro name, since defining a symbol as generic as "DEBUG" in a
> .h file that is pulled in by a lot of drivers is probably producing
> little bits of chaos in other parts of the kernel that nobody has
> noticed.

Linux-2.3.29 has fixed this and calls it IRDA_DEBUG. So we should just fix
this for 2.2.13 as well. Hmm, I guess I have to download 2.2.13-irda9, and
make a separate patch for it. Dropping in the 1Mb IrDA patch from 2.3.X is
probably out of the question ;-)

-- Dag

-- 
   / Dag Brattli                   | The Linux-IrDA Project               /
  // University of Tromsoe, Norway | Infrared communication for Linux    //
 /// http://www.cs.uit.no/~dagb    | http://www.cs.uit.no/linux-irda/   ///

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/