Re: [2.3.15] Misleading patch to sb_ess.c

Oleg Drokin (green@ccssu.crimea.ua)
Thu, 26 Aug 1999 15:39:46 +0300 (EEST)


Hello!

> > /* AAS: info stolen from ALSA: these boards have different clocks */
> > switch(devc->submodel) {
> > +/* APPARENTLY NOT 1869
> > + case SUBMDL_ES1869:
> > +*/
> > + case SUBMDL_ES1887:
> > + case SUBMDL_ES1888:
> > + devc->caps |= SB_CAP_ES18XX_RATE;
> >
> > This is wrong as it is noop!
> > I ask to apply following patch to 2.3.15 to get ESS1869 to back work
> > at normal speed:
> Your patch does the same as mine for the 1869 - it doesnt set ES18XX_RATE.
Sure it is. But the hunk above is from patch-2.3.15. And in result we
have insane code in sb_ess.c! 2 identical switch statements,
except that one of choises is commented out.
We can safely remove second switch, and a commend in the first
(if you tell me that it works for some people this way).
*And* specify in documentation, that if ESS1869 plays sounds too
slow, then specify 'esstype=-1' as module parameter to sb.o

/* AAS: info stolen from ALSA: these boards have different clocks */
switch(devc->submodel) {
/* APPARENTLY NOT 1869
case SUBMDL_ES1869:
*/
case SUBMDL_ES1887:
case SUBMDL_ES1888:
devc->caps |= SB_CAP_ES18XX_RATE;
break;
}

/* AAS: info stolen from ALSA: these boards have different clocks */
switch(devc->submodel) {
case SUBMDL_ES1869:
case SUBMDL_ES1887:
case SUBMDL_ES1888:
devc->caps |= SB_CAP_ES18XX_RATE;
break;
}

> People are still trying to figure this stuff out - it seems its config
> dependant not just board dependant 8(
Why not make parameter, then? e.g ess1968=slow/fast?
It only makes sence if one board does not swith behaviour while
in the one PC only.

Bye,
Oleg

-- 
 [RAVE *SUCKS* TEAM] [Team $Ui(iDE] [Trans-M Must Die!] [Sepultura Fans Team]
                         [Tolkien forever team]

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/