>> Next, a for loop that does absolutely nothing, although the fact
>> is hidden by the location of the semicolon. This patch unhides
>> that fact, although I'd guess that it's actually a bug that
>> needs some attention.
> I expect it's deliberate, the 'contents' of the loop are inside
> the for statement.
They possibly are, but when I first looked at it, I assumed that the
for loop immediately following it was inside that for loop, and
couldn't work out what was going on as a result. This patch prevents
that confusion in the approved fashion...
> You're not saying that
>> for (r = 0; rate < 75000000/ADCMULT; r += 0x20, rate <<= 1);
> generates a compiler warning now? Grrr :)
No, but it's only two lines away from the previous patch in that
message which did generate a compiler warning - I spotted that one
trying to sort out the first...
Best wishes from Riley.
+----------------------------------------------------------------------+
| There is something frustrating about the quality and speed of Linux |
| development, ie., the quality is too high and the speed is too high, |
| in other words, I can implement this XXXX feature, but I bet someone |
| else has already done so and is just about to release their patch. |
+----------------------------------------------------------------------+
* ftp://ftp.MemAlpha.cx/pub/rhw/Linux
* http://www.MemAlpha.cx/kernel.versions.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/