Re: IFF_UP vs IFF_RUNNING

Gergely Madarasz (gorgo@sztaki.hu)
Mon, 12 Jul 1999 15:26:02 +0200 (MET DST)


On Mon, 12 Jul 1999 kuznet@ms2.inr.ac.ru wrote:

> Hello!
>
> > I think you didn't understand it. My patch against syncppp.c (and
> > net/core/dev.c) allows IFF_RUNNING to be set by the link protocol driver,
> > while IFF_UP is set by dev.c only.
>
> Changing dev->flags in any place different of dev.c is bug (pretty harmless).
> But if you change it at BH or IRQ, it is serious bug.

Could you please explain a bit ?

> I understand your enthusiasm, but try to keep administrative things
> and link state separately yet and to protect things changed by interrupts
> properly.

I've done it when Alan suggested me to do it that way. What is your
suggestion on how to handle the problem of getting the state of a link
protocol from outside of the link protocol driver ?

Greg

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/