Re: [RFC] change of lookup() method.

Magnus Ahltorp (map@stacken.kth.se)
12 Apr 1999 15:11:50 +0200

Messages sorted by: [ date ][ thread ][ subject ][ author ]
Next message: Eric Werme USG: "Re: NFSv3 client for Linux-2.2.5 ready for alpha testing..."
Previous message: alex.buell@tahallah.demon.co.uk: "Re: Fun topic: name that branch!"
In reply to: Alexander Viro: "[RFC] change of lookup() method."

> Folks, right now we have ->lookup() returning 0 in case of success
> (in which case the argument gets hashed and becomes either positive or
> negative) or a negative integer in case of error (too long name, etc.).
> Proposed change: make it return a pointer to struct dentry.
> Semantics:
> NULL - old one would return 0.
> ERR_PTR(-foo) - old one would return foo.
> normal pointer - we got an alias dentry; act as if you've passed
> it to ->lookup() and it returned 0.
> (notice that it is binary compatible with the current variant, i.e. it
> doesn't break existing modules).

This would be very good for Arla too, since right now, I'm doing some
magic just to make it install the inode into the passed dentry.

I'm not quite sure what semantics you are proposing, though. If
real_lookup receives a normal pointer from ->lookup, what does it do
with the passed dentry? Just dput() and use the new value?

/Magnus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

Next message: Eric Werme USG: "Re: NFSv3 client for Linux-2.2.5 ready for alpha testing..."
Previous message: alex.buell@tahallah.demon.co.uk: "Re: Fun topic: name that branch!"
In reply to: Alexander Viro: "[RFC] change of lookup() method."