--2008762185-1804928587-915191222=:12812
Content-Type: TEXT/PLAIN; charset=US-ASCII
Hi Linus!
Could you please revert the patch you got for binfmt_misc?
Its wrong as it leaves binfmt_misc in a completely unusuable
state if CONFIG_PROC_FS is not set. (patch to revert the
changes and one pending change from me (remove stale variable)
is attached)
Although there is no chance of misconfiguration if one reads
the Configure.help entry, to prevent even silly misconfiguration
you may consider patch #2, that makes CONFIG_PROC_FS depend
on CONFIG_BINFMT_MISC (yes, I dont like the order, too - but
there is no way to make CONFIG_BINFMT_MISC depend on CONFIG_PROC_FS),
or alternatively patch #3, that makes binfmt_misc compile
conditionaly on CONFIG_PROC_FS (i.e. it leaves the user without
binfmt_misc, if he/she was unable to select CONFIG_PROC_FS).
Thanx, Richard.
PS: it seems, this patch was caused by a "random config compile" -
naaah... :(
-- Richard Guenther <richard.guenther@student.uni-tuebingen.de> PGP: 2E829319 - 2F 83 FC 93 E9 E4 19 E2 93 7A 32 42 45 37 23 57 WWW: http://www.anatom.uni-tuebingen.de/~richi/--2008762185-1804928587-915191222=:12812 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="binfmt_misc-patch-2.2.0-pre2" Content-Transfer-Encoding: BASE64 Content-ID: <Pine.HPP.3.96.990101124702.12812B@fphp16.tphys.physik.uni-tuebingen.de> Content-Description: revert changes to binfmt_misc
LS0tIGxpbnV4LTIuMi4wLXByZTIvZnMvYmluZm10X21pc2MuYy5vcmlnaW5h bAlUaHUgRGVjIDMxIDE4OjIzOjU3IDE5OTgNCisrKyBsaW51eC0yLjIuMC1w cmUyL2ZzL2JpbmZtdF9taXNjLmMJVGh1IERlYyAzMSAxODozODo1OSAxOTk4 DQpAQCAtNjcsNyArNjcsNyBAQA0KIHN0YXRpYyBpbnQgZnJlZV9pZCA9IDE7 DQogc3RhdGljIGludCBlbmFibGVkID0gMTsNCiANCi0jaWZkZWYgX19TTVBf Xw0KKyNpZmRlZiBDT05GSUdfU01QDQogc3RhdGljIHJ3bG9ja190IGVudHJp ZXNfbG9jayA9IFJXX0xPQ0tfVU5MT0NLRUQ7DQogI2VuZGlmDQogDQpAQCAt MTc5LDI2ICsxNzksMjMgQEANCiAJc3RydWN0IGRlbnRyeSAqIGRlbnRyeTsN CiAJY2hhciBpbmFtZVsxMjhdOw0KIAljaGFyICppbmFtZV9hZGRyID0gaW5h bWU7DQotCWludCByZXR2YWwsIGZtdF9mbGFncyA9IDA7DQorCWludCByZXR2 YWw7DQogDQogCU1PRF9JTkNfVVNFX0NPVU5UOw0KLQlpZiAoIWVuYWJsZWQp IHsNCi0JCXJldHZhbCA9IC1FTk9FWEVDOw0KKwlyZXR2YWwgPSAtRU5PRVhF QzsNCisJaWYgKCFlbmFibGVkKQ0KIAkJZ290byBfcmV0Ow0KLQl9DQogDQog CS8qIHRvIGtlZXAgbG9ja2luZyB0aW1lIGxvdywgd2UgY29weSB0aGUgaW50 ZXJwcmV0ZXIgc3RyaW5nICovDQogCXJlYWRfbG9jaygmZW50cmllc19sb2Nr KTsNCi0JaWYgKChmbXQgPSBjaGVja19maWxlKGJwcm0pKSkgew0KKwlmbXQg PSBjaGVja19maWxlKGJwcm0pOw0KKwlpZiAoZm10KSB7DQogCQlzdHJuY3B5 KGluYW1lLCBmbXQtPmludGVycHJldGVyLCAxMjcpOw0KIAkJaW5hbWVbMTI3 XSA9ICdcMCc7DQotCQlmbXRfZmxhZ3MgPSBmbXQtPmZsYWdzOw0KIAl9DQog CXJlYWRfdW5sb2NrKCZlbnRyaWVzX2xvY2spOw0KLQlpZiAoIWZtdCkgew0K LQkJcmV0dmFsID0gLUVOT0VYRUM7DQorCWlmICghZm10KQ0KIAkJZ290byBf cmV0Ow0KLQl9DQogDQogCWRwdXQoYnBybS0+ZGVudHJ5KTsNCiAJYnBybS0+ ZGVudHJ5ID0gTlVMTDsNCkBAIC0yMDksMTAgKzIwNiw5IEBADQogCWJwcm0t PmFyZ2MrKzsNCiAJYnBybS0+cCA9IGNvcHlfc3RyaW5ncygxLCAmaW5hbWVf YWRkciwgYnBybS0+cGFnZSwgYnBybS0+cCwgMik7DQogCWJwcm0tPmFyZ2Mr KzsNCi0JaWYgKCFicHJtLT5wKSB7DQotCQlyZXR2YWwgPSAtRTJCSUc7DQor CXJldHZhbCA9IC1FMkJJRzsNCisJaWYgKCFicHJtLT5wKQ0KIAkJZ290byBf cmV0Ow0KLQl9DQogCWJwcm0tPmZpbGVuYW1lID0gaW5hbWU7CS8qIGZvciBi aW5mbXRfc2NyaXB0ICovDQogDQogCWRlbnRyeSA9IG9wZW5fbmFtZWkoaW5h bWUsIDAsIDApOw0KQEAgLTQ1Miw5ICs0NDgsNyBAQA0KICAqLw0KIHN0YXRp YyB2b2lkIGVudHJ5X3Byb2NfY2xlYW51cChzdHJ1Y3QgYmluZm10X2VudHJ5 ICplKQ0KIHsNCi0jaWZkZWYgQ09ORklHX1BST0NfRlMNCiAJcmVtb3ZlX3By b2NfZW50cnkoZS0+cHJvY19uYW1lLCBibV9kaXIpOw0KLSNlbmRpZg0KIH0N CiANCiAvKg0KQEAgLTQ2Miw3ICs0NTYsNiBAQA0KICAqLw0KIHN0YXRpYyBp bnQgZW50cnlfcHJvY19zZXR1cChzdHJ1Y3QgYmluZm10X2VudHJ5ICplKQ0K IHsNCi0jaWZkZWYgQ09ORklHX1BST0NfRlMNCiAJaWYgKCEoZS0+cHJvY19k aXIgPSBjcmVhdGVfcHJvY19lbnRyeShlLT5wcm9jX25hbWUsDQogCQkJIAlT X0lGUkVHIHwgU19JUlVHTyB8IFNfSVdVU1IsIGJtX2RpcikpKQ0KIAkJcmV0 dXJuIC1FTk9NRU07DQpAQCAtNDcwLDcgKzQ2Myw2IEBADQogCWUtPnByb2Nf ZGlyLT5kYXRhID0gKHZvaWQgKikgKGUtPmlkKTsNCiAJZS0+cHJvY19kaXIt PnJlYWRfcHJvYyA9IHByb2NfcmVhZF9zdGF0dXM7DQogCWUtPnByb2NfZGly LT53cml0ZV9wcm9jID0gcHJvY193cml0ZV9zdGF0dXM7DQotI2VuZGlmDQog CXJldHVybiAwOw0KIH0NCiANCkBAIC00OTUsNyArNDg3LDYgQEANCiBpbnQg X19pbml0IGluaXRfbWlzY19iaW5mbXQodm9pZCkNCiB7DQogCWludCBlcnJv ciA9IC1FTk9NRU07DQotI2lmZGVmIENPTkZJR19QUk9DX0ZTDQogCXN0cnVj dCBwcm9jX2Rpcl9lbnRyeSAqc3RhdHVzID0gTlVMTCwgKnJlZzsNCiANCiAJ Ym1fZGlyID0gY3JlYXRlX3Byb2NfZW50cnkoInN5cy9mcy9iaW5mbXRfbWlz YyIsIFNfSUZESVIsIE5VTEwpOw0KQEAgLTUxNiw3ICs1MDcsNiBAQA0KIAlp ZiAoIXJlZykNCiAJCWdvdG8gY2xlYW51cF9zdGF0dXM7DQogCXJlZy0+d3Jp dGVfcHJvYyA9IHByb2Nfd3JpdGVfcmVnaXN0ZXI7DQotI2VuZGlmIC8qIENP TkZJR19QUk9DX0ZTICovDQogDQogCWVycm9yID0gcmVnaXN0ZXJfYmluZm10 KCZtaXNjX2Zvcm1hdCk7DQogb3V0Og0K --2008762185-1804928587-915191222=:12812 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="binfmt_misc-config.diff" Content-Transfer-Encoding: BASE64 Content-ID: <Pine.HPP.3.96.990101124702.12812C@fphp16.tphys.physik.uni-tuebingen.de> Content-Description: config_proc depend on config_binfmt_misc
LS0tIGxpbnV4LTIuMi4wLXByZTIvZnMvQ29uZmlnLmluLm9yaWdpbmFsCVRo dSBEZWMgMzEgMTg6MTg6NTcgMTk5OA0KKysrIGxpbnV4LTIuMi4wLXByZTIv ZnMvQ29uZmlnLmluCVRodSBEZWMgMzEgMTg6MjI6MzggMTk5OA0KQEAgLTMw LDcgKzMwLDExIEBADQogICBib29sICcgICBOVEZTIHJlYWQtd3JpdGUgc3Vw cG9ydCAoZXhwZXJpbWVudGFsKScgQ09ORklHX05URlNfUlcNCiBmaQ0KIHRy aXN0YXRlICdPUy8yIEhQRlMgZmlsZXN5c3RlbSBzdXBwb3J0IChyZWFkIG9u bHkpJyBDT05GSUdfSFBGU19GUw0KLWJvb2wgJy9wcm9jIGZpbGVzeXN0ZW0g c3VwcG9ydCcgQ09ORklHX1BST0NfRlMNCitpZiBbICIkQ09ORklHX0JJTkZN VF9NSVNDIiAhPSAibiIgXTsgdGhlbg0KKyAgZGVmaW5lX2Jvb2wgQ09ORklH X1BST0NfRlMgeQ0KK2Vsc2UgDQorICBib29sICcvcHJvYyBmaWxlc3lzdGVt IHN1cHBvcnQnIENPTkZJR19QUk9DX0ZTDQorZmkNCiBpZiBbICIkQ09ORklH X1VOSVg5OF9QVFlTIiA9ICJ5IiBdOyB0aGVuDQogICB0cmlzdGF0ZSAnL2Rl di9wdHMgZmlsZXN5c3RlbSBmb3IgVW5peDk4IFBUWXMnIENPTkZJR19ERVZQ VFNfRlMNCiBmaQ0K --2008762185-1804928587-915191222=:12812 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="binfmt_misc-makefile.diff" Content-Transfer-Encoding: BASE64 Content-ID: <Pine.HPP.3.96.990101124702.12812D@fphp16.tphys.physik.uni-tuebingen.de> Content-Description: compile binfmt_misc conditionally
LS0tIGxpbnV4LTIuMi4wLXByZTIvZnMvTWFrZWZpbGUub3JpZ2luYWwJVGh1 IERlYyAzMSAxODoyODoyMSAxOTk4DQorKysgbGludXgtMi4yLjAtcHJlMi9m cy9NYWtlZmlsZQlUaHUgRGVjIDMxIDE4OjI4OjIzIDE5OTgNCkBAIC0yNzIs MTEgKzI3MiwxMyBAQA0KIGVuZGlmDQogDQogDQotaWZlcSAoJChDT05GSUdf QklORk1UX01JU0MpLHkpDQotQklORk1UUyArPSBiaW5mbXRfbWlzYy5vDQot ZWxzZQ0KLSAgaWZlcSAoJChDT05GSUdfQklORk1UX01JU0MpLG0pDQotICBN X09CSlMgKz0gYmluZm10X21pc2Mubw0KK2lmZXEgKCQoQ09ORklHX1BST0Nf RlMpLHkpDQorICBpZmVxICgkKENPTkZJR19CSU5GTVRfTUlTQykseSkNCisg IEJJTkZNVFMgKz0gYmluZm10X21pc2Mubw0KKyAgZWxzZQ0KKyAgICBpZmVx ICgkKENPTkZJR19CSU5GTVRfTUlTQyksbSkNCisgICAgTV9PQkpTICs9IGJp bmZtdF9taXNjLm8NCisgICAgZW5kaWYNCiAgIGVuZGlmDQogZW5kaWYNCiAN Cg== --2008762185-1804928587-915191222=:12812--
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/