Re: [patch] jiffies wraparound [Re: 2.1.125 Show stopper list: Draft]

Andrea Arcangeli (andrea@e-mind.com)
Sat, 17 Oct 1998 21:16:13 +0200 (CEST)


On Fri, 16 Oct 1998, Andrea Arcangeli wrote:

>This part of the new jiffies-5 patch should fix the get_fast_timeoffset()
>jiffies wrap bug (extracted from the now patch and posted to the list to
>allow more people to complain). Note that JIFFIES_OFFSET should be set to
>0 for production. My patch set it to -120*HZ _only_ to allow catching wrap
>bugs.

OK. I fixed a bug in my jiffies-5, but now there are other very big
problems in schedule() about the jiffies wrap bug (and I think it' s
better to ask before continue).

Schedule() think that prev->timeout == 0 has a special menaning, while
when it' s 0 simply it means that jiffies is near to wrap and must be
used as a normal value if we want to be jiffies wrap compliant.

I think a safe (safe because the complier will allow us to not fail) and
strightforward way to fix this major wrap bug in schedule() is to change
timeout in timeout_value and to add a new bitwise flag called use_timeout
in the task struct. This new flag will tell us if we have to check the
timeout value or if we must sleep forever waiting for a signal.

Linus are you worried to fix the jiffies wrap bug?

Andrea Arcangeli

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/