Re: [PATCH, revised & tested] Adaptec AHA152x

Eastep, Tom (eastep@loc1.tandem.com)
Fri, 16 Oct 1998 12:35:52 -0700


David,

David Woodhouse wrote:
>
> This one is now tested and a couple of bugs fixed.
>
> Now that it doesn't crash the whole machine each time you get the IO/IRQ
> parameters wrong, I was able to establish the identity of another aha152x
> card, and get the thing working. So I have been able to test it.
>
> Unless I hear otherwise, I'll thrash it a bit overnight and submit it to Linus
> in the morning.

I just discovered that your patch breaks when CONFIG_AHA152X=y (syntax errors in
drivers/scsi/hosts.c). The following trivial patch corrects the problem:


diff -u linux/drivers/scsi/aha152x.h~ linux/drivers/scsi/aha152x.h
--- linux/drivers/scsi/aha152x.h~ Fri Oct 16 12:13:38 1998
+++ linux/drivers/scsi/aha152x.h Fri Oct 16 12:18:04 1998
@@ -15,6 +15,7 @@
int aha152x_command(Scsi_Cmnd *);
int aha152x_queue(Scsi_Cmnd *, void (*done)(Scsi_Cmnd *));
int aha152x_abort(Scsi_Cmnd *);
+int aha152x_release(struct Scsi_Host *shpnt);
int aha152x_reset(Scsi_Cmnd *, unsigned int);
int aha152x_biosparam(Disk *, kdev_t, int*);
int aha152x_proc_info(char *buffer, char **start, off_t offset, int length, int
hostno, int inout);

Cheers,
Tom

-- 
Tom Eastep	
COMPAQ Computer Corporation
Enterprise Computing Group
Tandem Division
tom.eastep@compaq.com

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/