Re: New pre-patch (Re: [PATCH] kswapd fully sysctl tunable)

Linus Torvalds (torvalds@transmeta.com)
Sun, 3 May 1998 17:59:44 -0700 (PDT)

On Sun, 3 May 1998, Gerard Roudier wrote:
>
> > small patch that involves moving the "ack_APIC_irq();" inside
> > arch/i386/kernel/irq.c: do_ioapic_IRQ() from the top of the function to
> > the very bottom of that function (that will move it to outside the irq
> > controller lock, but it should actually be perfectly ok in this case).
>
> If this will have the expected effect, this will be fine.
> BTW, I cannot help for testing this stuff since I only have UP.

Note that the apic code really isn't SMP-specific at all, and is valid on
its own. It does have a strong link to SMP mainly because the MP table
contains the PCI routing information, but even that really isn't a SMP
issue.

So if somebody feels interested, it might be a good idea to split up the
_real_ SMP code from the code that should be merely "CONFIG_APIC". That
would give it more wider testing - and the newer APIC makes sense even on
UP if for no other reason than the fact that is is much lower latency.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu