net-tools bug causes ifconfig stats error and patch

Mike Black (mblack@csihq.com)
Wed, 25 Mar 1998 06:23:07 -0500


This is a multi-part message in MIME format.

------=_NextPart_000_00C4_01BD57B6.79B52160
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: 7bit

net-tools 1.432
ifconfig 1.29 (1997-09-23)

ifconfig.c parses /proc/net/dev incorrectly for Linux 2.1.90 (happened
sometime earlier). I saw this problem mentioned in the kernel mailing list.

There are now 16 arguments to parse and it screws up the stats by a couple
of columns.

Here's my proc/net/dev:
Inter-| Receive | Transmit
face |bytes packets errs drop fifo frame compressed multicast|bytes
packets errs drop fifo colls carrier compressed
lo: 1669029 15115 0 0 0 0 0 0 1669029
15115 0 0 0 0 0 0
eth0: 0 54969 0 0 0 0 0 0 0
25659 0 0 0 1 0 0
gre0: 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0

The addition is compressed/multicast on the rx side and compressed on the tx
side. Perchance the code should check the headers to ensure it matches the
expected format and give a warning?

Is there a newer version?

I've attached a patch that fixes the problem.
_________________________________________________________
Mike Black mblack@csihq.com
407-676-2923, x203 FAX 407-676-2355
Computer Science Innovations, Inc. http://www.csihq.com

------=_NextPart_000_00C4_01BD57B6.79B52160
Content-Type: application/octet-stream;
name="ifconfig.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="ifconfig.patch"

KioqIGlmY29uZmlnLmMub2xkCVdlZCBNYXIgMjUgMDY6MTk6MjggMTk5OAotLS0gaWZjb25maWcu
YwlXZWQgTWFyIDI1IDA2OjIwOjExIDE5OTgKKioqKioqKioqKioqKioqCioqKiA5Miw5NyAqKioq
Ci0tLSA5Miw5OCAtLS0tCiAgICB1bnNpZ25lZCBsb25nCXJ4X292ZXJfZXJyb3JzOwkvKiByZWNl
aXZlciByaW5nIGJ1ZmYgb3ZlcmZsb3cJKi8KICAgIHVuc2lnbmVkIGxvbmcJcnhfY3JjX2Vycm9y
czsJLyogcmVjdmVkIHBrdCB3aXRoIGNyYyBlcnJvcgkqLwogICAgdW5zaWduZWQgbG9uZwlyeF9m
cmFtZV9lcnJvcnM7IC8qIHJlY3YnZCBmcmFtZSBhbGlnbm1lbnQgZXJyb3IgKi8KKyAgIHVuc2ln
bmVkIGxvbmcJcnhfY29tcHJlc3NlZDsgCiAgICB1bnNpZ25lZCBsb25nCXJ4X2ZpZm9fZXJyb3Jz
OwkvKiByZWN2J3IgZmlmbyBvdmVycnVuCQkqLwogICAgdW5zaWduZWQgbG9uZwlyeF9taXNzZWRf
ZXJyb3JzOyAvKiByZWNlaXZlciBtaXNzZWQgcGFja2V0CSovCiAgICAvKiBkZXRhaWxlZCB0eF9l
cnJvcnMgKi8KKioqKioqKioqKioqKioqCioqKiAxMDAsMTA1ICoqKioKLS0tIDEwMSwxMDcgLS0t
LQogICAgdW5zaWduZWQgbG9uZwl0eF9maWZvX2Vycm9yczsKICAgIHVuc2lnbmVkIGxvbmcJdHhf
aGVhcnRiZWF0X2Vycm9yczsKICAgIHVuc2lnbmVkIGxvbmcJdHhfd2luZG93X2Vycm9yczsKKyAg
IHVuc2lnbmVkIGxvbmcJdHhfY29tcHJlc3NlZDsgCiAgfTsKICAKICBzdHJ1Y3QgaW50ZXJmYWNl
IHsKKioqKioqKioqKioqKioqCioqKiA0MDEsNDEzICoqKioKICAgICAgICBicD1zdHJjaHIoYnAs
JzonKTsKICAgICAgICBicCsrOwogICAgICAgIGlmIChoYXZlX2J5dGVfY291bnRlcnMpIHsKISAJ
c3NjYW5mKGJwLCIlbGQgJWxkICVsZCAlbGQgJWxkICVsZCAlbGQgJWxkICVsZCAlbGQgJWxkICVs
ZCAlbGQiLAogIAkgICAgICAgJmlmZS0+c3RhdHMucnhfYnl0ZXMsCiAgCSAgICAgICAmaWZlLT5z
dGF0cy5yeF9wYWNrZXRzLAogIAkgICAgICAgJmlmZS0+c3RhdHMucnhfZXJyb3JzLAogIAkgICAg
ICAgJmlmZS0+c3RhdHMucnhfZHJvcHBlZCwKICAJICAgICAgICZpZmUtPnN0YXRzLnJ4X2ZpZm9f
ZXJyb3JzLAogIAkgICAgICAgJmlmZS0+c3RhdHMucnhfZnJhbWVfZXJyb3JzLAogIAkgICAgICAg
CiAgCSAgICAgICAmaWZlLT5zdGF0cy50eF9ieXRlcywKICAJICAgICAgICZpZmUtPnN0YXRzLnR4
X3BhY2tldHMsCi0tLSA0MDMsNDE3IC0tLS0KICAgICAgICBicD1zdHJjaHIoYnAsJzonKTsKICAg
ICAgICBicCsrOwogICAgICAgIGlmIChoYXZlX2J5dGVfY291bnRlcnMpIHsKISAJc3NjYW5mKGJw
LCIlbGQgJWxkICVsZCAlbGQgJWxkICVsZCAlbGQgJWxkICVsZCAlbGQgJWxkICVsZCAlbGQgJWxk
ICVsZCAlbGQiLAogIAkgICAgICAgJmlmZS0+c3RhdHMucnhfYnl0ZXMsCiAgCSAgICAgICAmaWZl
LT5zdGF0cy5yeF9wYWNrZXRzLAogIAkgICAgICAgJmlmZS0+c3RhdHMucnhfZXJyb3JzLAogIAkg
ICAgICAgJmlmZS0+c3RhdHMucnhfZHJvcHBlZCwKICAJICAgICAgICZpZmUtPnN0YXRzLnJ4X2Zp
Zm9fZXJyb3JzLAogIAkgICAgICAgJmlmZS0+c3RhdHMucnhfZnJhbWVfZXJyb3JzLAorIAkgICAg
ICAgJmlmZS0+c3RhdHMucnhfY29tcHJlc3NlZCwKKyAJICAgICAgICZpZmUtPnN0YXRzLm11bHRp
Y2FzdCwKICAJICAgICAgIAogIAkgICAgICAgJmlmZS0+c3RhdHMudHhfYnl0ZXMsCiAgCSAgICAg
ICAmaWZlLT5zdGF0cy50eF9wYWNrZXRzLAoqKioqKioqKioqKioqKioKKioqIDQxNiw0MjIgKioq
KgogIAkgICAgICAgJmlmZS0+c3RhdHMudHhfZmlmb19lcnJvcnMsCiAgCSAgICAgICAmaWZlLT5z
dGF0cy5jb2xsaXNpb25zLAogIAkgICAgICAgCiEgCSAgICAgICAmaWZlLT5zdGF0cy50eF9jYXJy
aWVyX2Vycm9ycwogIAkgICAgICAgKTsKICAgICAgICB9IGVsc2UgewogIAlzc2NhbmYoYnAsIiVs
ZCAlbGQgJWxkICVsZCAlbGQgJWxkICVsZCAlbGQgJWxkICVsZCAlbGQiLAotLS0gNDIwLDQyNyAt
LS0tCiAgCSAgICAgICAmaWZlLT5zdGF0cy50eF9maWZvX2Vycm9ycywKICAJICAgICAgICZpZmUt
PnN0YXRzLmNvbGxpc2lvbnMsCiAgCSAgICAgICAKISAJICAgICAgICZpZmUtPnN0YXRzLnR4X2Nh
cnJpZXJfZXJyb3JzLAohIAkgICAgICAgJmlmZS0+c3RhdHMudHhfY29tcHJlc3NlZAogIAkgICAg
ICAgKTsKICAgICAgICB9IGVsc2UgewogIAlzc2NhbmYoYnAsIiVsZCAlbGQgJWxkICVsZCAlbGQg
JWxkICVsZCAlbGQgJWxkICVsZCAlbGQiLAo=

------=_NextPart_000_00C4_01BD57B6.79B52160--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu