Re: sound & 2.1.x (latest vers)

David Woodhouse (Dave@imladris.demon.co.uk)
Wed, 14 Jan 1998 12:40:10 +0000

bofh@snoopy.virtual.net.au said:
> I don't really know why this fix is needed. The code in the
> makefile looks good. I believe that my patch is the right thing to do
> though as I think that uart401 should be a module if SB is a module,
> and I don't think that there's any possible way of setting things
> otherwise.

> I'm just giving this out so that people like you can get things
> working while the people who understand the sound make files solve the
> real problem.

> diff -ru linux/drivers/sound/Makefile linux-patched/drivers/sound/
> Makefile --- linux/drivers/sound/Makefile Sat Jan 3 21:09:50
> 1998 +++ linux-patched/drivers/sound/Makefile Sat Jan 3
> 21:09:30 1998 @@ -95,9 +95,7 @@
> ifeq ($(CONFIG_SB),m)
> M_OBJS += sb.o
> MIX_OBJS += sb_card.o - ifneq ($(CONFIG_UART401),y)
> CONFIG_UART401 = m - endif
> endif
> endif

I believe that this would fall down if sb is a module, but uart401 is required
to be compiled statically because another driver depends on it.

In that (admittedly rather unlikely) case, the kernel link will fail because
of the missing uart401 functions.

The patch I posted handles that possibility, but probably needs extending to
cover static/module possibilities for other cards too. I'll wait for approval
from someone who understands the Makefiles better before bothering, though.

-- 
----                              ----                              ----
David Woodhouse, Robinson College, CB3 9AN, England.   (+44) 0976 658355
    Dave@imladris.demon.co.uk        http://dwmw2.robinson.cam.ac.uk
	    finger pgp@dwmw2.robinson.cam.ac.uk for PGP key.