I haven't compiled with your patch, but I've done a lot of work in this
area lately, so I took a look at it.
> - sb_audio_ioctl,
> + NULL, /* ioctl */
This looks proper to me. Whoever removed sb_audio_ioctl neglected to
search for all the instances.
> +void reprogram_timer(void);
Fine.
> +EXPORT_SYMBOL(reprogram_timer);
I believe this is unnecessary because reprogram_timer is used only
within sound_timer.c and sys_timer.c, which are in the same module.
But it's harmless.
> -static void
> +void
> reprogram_timer(void)
Proper.
It looks like some code got into 2.1.77 without sufficient testing.
What happened to the guidelines in MAINTAINERS, about posting
patches to the list, and getting other people to test them?
Michael Chastain
<mailto:mec@shout.net>
"love without fear"