broken drivers

C. Scott Ananian (cananian@lcs.mit.edu)
Fri, 31 Oct 1997 22:42:45 -0500 (EST)


Quite a number of drivers were broken by the recent prototype switch for
{driver}_read and {driver}_write. I thought it would perhaps be useful to
compile a list, so we knew what had to be fixed, and what to attribute
bug reports to. The following list was compiled by grepping for "_read"
and "inode" and manually reviewing the output:

net/netlink.c
drivers/block/acsi_slm.c
drivers/block/swim3.c
drivers/char/acquirewdt.c
drivers/char/apm_bios.c
drivers/char/dsp56k.c
drivers/char/fbmem.c
drivers/char/h8.c
drivers/char/joystick.c (recent patch on this list fixed this)
drivers/char/lp.c (I've got a patch for this; I'll post it tonight)
drivers/char/nvram.c
drivers/char/pcwd.c
drivers/char/tpqic02.c
drivers/char/wdt.c
drivers/isdn/isdn_common.c
drivers/macintosh/adb.c
drivers/scsi/53c7,8xx.c
drivers/sound/dmasound.c
drivers/sound/soundcard.c
fs/proc/net.c
fs/proc/omirr.c
fs/proc/openpromfs.c
--the umsdos filesystem, not limited to: --
fs/umsdos/dir.c
fs/umsdos/emd.c
fs/umsdoc/file.c (call to fat_file_read with old-style args)
fs/umsdos/inode.c (call to umsdos_emd_dir_read with old args)
fs/umsdos/symlink.c (call to msdos_read with old args, and others)
net/wanrouter/wanproc.c
arch/i386/kernel/mca.c
arch/ppc/kernel/ppc_htab.c
arch/sparc64/kernel/sys_sparc32.c (? -- I suspect badness in do_readv_writev32)
drivers/char/ftape/kernel-interface.c
drivers/isdn/avmb1/capi.c
drivers/sbus/audio/audio.c
drivers/sbus/char/bpp.c
drivers/sbus/char/sunkbd.c
drivers/sbus/char/sunmounse.c
fs/ncpfs/{dir|file}.c (? -- other badness probably present here)
--------------------

As a quick summary, this means that linux 2.1.6[01] is probably unusable
on a sparc (no mouse, keyboard), on mca and ppc machines, and on systems
relying on the umsdos filesystem. Many other things broken, too, of
course.
--Scott
@ @
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-oOO-(_)-OOo-=-=-=-=-=
C. Scott Ananian: cananian@lcs.mit.edu / Declare the Truth boldly and
Laboratory for Computer Science/Crypto / without hindrance.
Massachusetts Institute of Technology /META-PARRESIAS AKOLUTOS:Acts 28:31
-.-. .-.. .. ..-. ..-. --- .-. -.. ... -.-. --- - - .- -. .- -. .. .- -.
PGP key available via finger and from http://www.pdos.lcs.mit.edu/~cananian