Re: confusion in apricot.c

Florian La Roche (florian@knorke.saar.de)
Sun, 20 Jul 1997 14:16:57 +0200


> I find warnings annoying so I took a look and the file. It contains pieces
> of code like:
>
> while (lp->scb.status, lp->scb.command)
> ....
>
> Is this simply a result of an over enthusiastic search/replace or was there
> some intended action that's not quite made it into the kernel yet?

Just make a patch that changes those lines to:
while (lp->scb.command)

For a comma-separated list, only the last value is used. So as long
as you don't have any calls to functions, you can remove those statements.

Linus has already accepted my patch for the 2.1.x-kernels that changes
these things.

Greetings,

Florian