Re: [BUG] ppp/slip fails with 1.3.6[78]

Linus Torvalds (Linus.Torvalds@cs.helsinki.fi)
Sat, 24 Feb 1996 14:36:14 +0200


Robert Riggs: "[BUG] ppp/slip fails with 1.3.6[78]" (Feb 24, 5:04):
> I traced my problems with ppp/slip not working to this
> section of the 1.3.67 patch:
>
> --- include/asm-i386/termios.h Sat Feb 24 04:23:03 1996
> +++ include/asm-i386/termios.h.new Fri Feb 23 11:35:15 1996
> @@ -268,6 +268,8 @@
>
> #ifdef __KERNEL__
>
> +#include <linux/string.h>
> +
> /*
> * Translate a "termio" structure into a "termios". Ugh.
> */
>
>
> Reversing this allows slip/ppp to connect.

That definitely does not make sense. What compiler are you using? The
only way I see for the above patch to break anything at all is a
compiler bug when compiling the kernel.

Or maybe some old out-of-date object file just got re-compiled correctly
when you changed termios.h?

Linus