Re: [PATCH 3/3] ALSA: hda/tas2781: add debug statements to kcontrols

From: Pierre-Louis Bossart
Date: Mon Mar 25 2024 - 18:01:30 EST





> +++ b/sound/pci/hda/tas2781_hda_i2c.c
> @@ -189,6 +189,9 @@ static int tasdevice_get_profile_id(struct snd_kcontrol *kcontrol,
>
> ucontrol->value.integer.value[0] = tas_priv->rcabin.profile_cfg_id;
>
> + dev_dbg(tas_priv->dev, "%s: %d\n", __func__,

Nit-pick: you don't need to add __func__ to dev_dbg logs, the user can
add the information with the dyndbg parameter, e.g.

options snd_intel_dspcfg dyndbg=+pmf

dev_err/warn don't have this functionality though so in those cases
there's no replacement for __func__