[PATCH 3/3] ALSA: hda/tas2781: add debug statements to kcontrols

From: Gergo Koteles
Date: Mon Mar 25 2024 - 17:26:48 EST


Sometimes it is useful to examine the timing of kcontrol events.

Add debug statements to each kcontrol.

Signed-off-by: Gergo Koteles <soyer@xxxxxx>
---
sound/pci/hda/tas2781_hda_i2c.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)

diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
index 9a43f563bb9e..b60ce4c2c090 100644
--- a/sound/pci/hda/tas2781_hda_i2c.c
+++ b/sound/pci/hda/tas2781_hda_i2c.c
@@ -189,6 +189,9 @@ static int tasdevice_get_profile_id(struct snd_kcontrol *kcontrol,

ucontrol->value.integer.value[0] = tas_priv->rcabin.profile_cfg_id;

+ dev_dbg(tas_priv->dev, "%s: %d\n", __func__,
+ tas_priv->rcabin.profile_cfg_id);
+
mutex_unlock(&tas_priv->codec_lock);

return 0;
@@ -206,6 +209,9 @@ static int tasdevice_set_profile_id(struct snd_kcontrol *kcontrol,

mutex_lock(&tas_priv->codec_lock);

+ dev_dbg(tas_priv->dev, "%s: %d -> %d\n", __func__,
+ tas_priv->rcabin.profile_cfg_id, val);
+
if (tas_priv->rcabin.profile_cfg_id != val) {
tas_priv->rcabin.profile_cfg_id = val;
ret = 1;
@@ -253,6 +259,8 @@ static int tasdevice_program_get(struct snd_kcontrol *kcontrol,

ucontrol->value.integer.value[0] = tas_priv->cur_prog;

+ dev_dbg(tas_priv->dev, "%s: %d\n", __func__, tas_priv->cur_prog);
+
mutex_unlock(&tas_priv->codec_lock);

return 0;
@@ -271,6 +279,9 @@ static int tasdevice_program_put(struct snd_kcontrol *kcontrol,

mutex_lock(&tas_priv->codec_lock);

+ dev_dbg(tas_priv->dev, "%s: %d -> %d\n", __func__,
+ tas_priv->cur_prog, val);
+
if (tas_priv->cur_prog != val) {
tas_priv->cur_prog = val;
ret = 1;
@@ -290,6 +301,8 @@ static int tasdevice_config_get(struct snd_kcontrol *kcontrol,

ucontrol->value.integer.value[0] = tas_priv->cur_conf;

+ dev_dbg(tas_priv->dev, "%s: %d\n", __func__, tas_priv->cur_conf);
+
mutex_unlock(&tas_priv->codec_lock);

return 0;
@@ -308,6 +321,9 @@ static int tasdevice_config_put(struct snd_kcontrol *kcontrol,

mutex_lock(&tas_priv->codec_lock);

+ dev_dbg(tas_priv->dev, "%s: %d -> %d\n", __func__,
+ tas_priv->cur_conf, val);
+
if (tas_priv->cur_conf != val) {
tas_priv->cur_conf = val;
ret = 1;
@@ -330,6 +346,9 @@ static int tas2781_amp_getvol(struct snd_kcontrol *kcontrol,

ret = tasdevice_amp_getvol(tas_priv, ucontrol, mc);

+ dev_dbg(tas_priv->dev, "%s: %ld\n", __func__,
+ ucontrol->value.integer.value[0]);
+
mutex_unlock(&tas_priv->codec_lock);

return ret;
@@ -345,6 +364,9 @@ static int tas2781_amp_putvol(struct snd_kcontrol *kcontrol,

mutex_lock(&tas_priv->codec_lock);

+ dev_dbg(tas_priv->dev, "%s: %ld\n", __func__,
+ ucontrol->value.integer.value[0]);
+
/* The check of the given value is in tasdevice_amp_putvol. */
ret = tasdevice_amp_putvol(tas_priv, ucontrol, mc);

--
2.44.0