Re: [PATCH V3] gpiolib: use dev_err() when gpiod_configure_flags failed

From: Andy Shevchenko
Date: Mon Mar 25 2024 - 13:18:20 EST


On Mon, Mar 25, 2024 at 04:48:27PM +0100, Bartosz Golaszewski wrote:
> On Fri, Mar 22, 2024 at 4:59 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Fri, Mar 22, 2024 at 9:29 AM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx> wrote:

..

> > Bart, are you aware that this will add yet another possibility of
> > scary '(null)' in the error level, which is much likely visible to the
> > end users?
> >
> > I propose to apply my fix first to avoid this happening.
> > 20240320165930.1182653-1-andriy.shevchenko@xxxxxxxxxxxxxxx
>
> I think you meant the v2[1]?

Yes!

> And sure, I will pick it up shortly.

Thank you!

> [1] https://lore.kernel.org/lkml/20240320165930.1182653-1-andriy.shevchenko@xxxxxxxxxxxxxxx/T/

I can update this patch (rebase it on top) if needed to make less burden on
the author's shoulders. Just tell me.

--
With Best Regards,
Andy Shevchenko