Re: [PATCH V3] gpiolib: use dev_err() when gpiod_configure_flags failed

From: Bartosz Golaszewski
Date: Mon Mar 25 2024 - 13:12:28 EST


On Fri, Mar 22, 2024 at 4:59 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Fri, Mar 22, 2024 at 9:29 AM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx> wrote:
> >
> > From: Peng Fan <peng.fan@xxxxxxx>
> >
> > When gpio-ranges property was missed to be added in the gpio node,
> > using dev_err() to show an error message will helping to locate issues
> > easier.
>
> Bart, are you aware that this will add yet another possibility of
> scary '(null)' in the error level, which is much likely visible to the
> end users?
>
> I propose to apply my fix first to avoid this happening.
> 20240320165930.1182653-1-andriy.shevchenko@xxxxxxxxxxxxxxx
>

I think you meant the v2[1]?

And sure, I will pick it up shortly.

Bart

[1] https://lore.kernel.org/lkml/20240320165930.1182653-1-andriy.shevchenko@xxxxxxxxxxxxxxx/T/