Re: [PATCH 6.1 00/71] 6.1.82-rc1 review

From: Ron Economos
Date: Fri Mar 15 2024 - 15:33:03 EST


On 3/15/24 7:49 AM, Jens Axboe wrote:
On 3/15/24 8:42 AM, Sasha Levin wrote:
On Fri, Mar 15, 2024 at 08:14:57AM -0400, Sasha Levin wrote:
On Thu, Mar 14, 2024 at 04:40:53PM -0600, Jens Axboe wrote:
On 3/14/24 4:35 PM, Sasha Levin wrote:
On Thu, Mar 14, 2024 at 04:04:59PM -0600, Jens Axboe wrote:
On 3/14/24 3:12 PM, Mateusz Jo?czyk wrote:
W dniu 13.03.2024 o 22:27, Mateusz Jo?czyk pisze:
W dniu 13.03.2024 o 21:13, Mateusz Jo?czyk pisze:
W dniu 13.03.2024 o 17:38, Sasha Levin pisze:
This is the start of the stable review cycle for the 6.1.82 release.
There are 71 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Fri Mar 15 04:39:56 PM UTC 2024.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/patch/?id=linux-6.1.y&id2=v6.1.81
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
and the diffstat can be found below.

Thanks,
Sasha

Hello,

Kernel hangs during early boot. No console messages, nothing in pstore.

Tested on a HP 17-by0001nw laptop with an Intel Kaby Lake CPU (Intel i3-7020U) and Ubuntu 20.04.

This CPU is not affected by RFDS (at least according to the Kconfig message), so I have set

CONFIG_MITIGATION_RFDS=n

in Kconfig. I do not have any updated microcode (if any will be provided at all for this CPU).

Greetings,

Mateusz

[snip]
Bisected down to

commit d3d517a95e83a7d89e1ff511da1a0a31c9234155
Author: Christoph Hellwig <hch@xxxxxx>
Date: Fri Feb 3 16:03:54 2023 +0100

blk-rq-qos: make rq_qos_add and rq_qos_del more useful
Do you have:

commit e33b93650fc5364f773985a3e961e24349330d97
Author: Breno Leitao <leitao@xxxxxxxxxx>
Date: Tue Feb 28 03:16:54 2023 -0800

blk-iocost: Pass gendisk to ioc_refresh_params

in there?
It's not in the 6.1 tree, do we need it?
If the bisected commit is in there, then yes we need it. It's marked as
fixes that, so puzzled why it isn't in there?
Sorry, I take it back - both e33b93650fc5 ("blk-iocost: Pass gendisk to
ioc_refresh_params") and d3d517a95e83 ("blk-rq-qos: make rq_qos_add and
rq_qos_del more useful") are currently in the 6.1 tree.
I didn't see e33b93650fc5 in there, but maybe it was part of the series
that this is about.

I'll go ahead and drop the backport of f814bdda774c ("blk-wbt: Fix
detection of dirty-throttled tasks") as well as the dependencies (which
is where this issue bisected to), and all follow-up fixes.

We can revisit this for the next release.
Sounds reasonable.

Seeing this on RISC-V also. Here's the oops.

[    2.030135] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000050
[    2.038233] Oops [#1]
[    2.040420] Modules linked in:
[    2.043461] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.1.82-rc1 #2
[    2.049717] Hardware name: SiFive HiFive Unmatched A00 (DT)
[    2.055276] epc : wbt_queue_depth_changed+0x18/0xb6
[    2.060138]  ra : wbt_init+0x118/0x198
[    2.063871] epc : ffffffff8050e942 ra : ffffffff8050f16e sp : ffffffd880087c80
[    2.071087]  gp : ffffffff81a3e3a8 tp : ffffffd87ffe8d40 t0 : ffffffdbfed53668
[    2.078294]  t1 : 0000000000000000 t2 : 0000000000000000 s0 : ffffffd880087ca0
[    2.085507]  s1 : ffffffd8800fa458 a0 : ffffffd8800fa458 a1 : ffffffff813442a8
[    2.092714]  a2 : ffffffff81b148e0 a3 : 00000000001e8480 a4 : 0000000000000000
[    2.099923]  a5 : 0000000000000000 a6 : 0000000000000000 a7 : 0000000000000000
[    2.107131]  s2 : ffffffd88086a800 s3 : ffffffd880870000 s4 : ffffffd8808702c0
[    2.114340]  s5 : ffffffd880870088 s6 : ffffffd8808702a0 s7 : ffffffff80e6d580
[    2.121550]  s8 : 0000000000000008 s9 : ffffffff80c00106 s10: 0000000000000000
[    2.128759]  s11: 0000000000000000 t3 : 0000000000000000 t4 : 0000000000000000
[    2.135967]  t5 : 0000000000000000 t6 : 0000000000000000
[    2.141264] status: 0000000200000120 badaddr: 0000000000000050 cause: 000000000000000d
[    2.149171] [<ffffffff8050e942>] wbt_queue_depth_changed+0x18/0xb6
[    2.155337] [<ffffffff8050f16e>] wbt_init+0x118/0x198
[    2.160371] [<ffffffff8050f25a>] wbt_enable_default+0x6c/0x90
[    2.166104] [<ffffffff804d7822>] blk_register_queue+0x17c/0x1b2
[    2.172012] [<ffffffff804ec420>] device_add_disk+0x1f6/0x36c
[    2.177657] [<ffffffff806c3e7a>] loop_add+0x2a0/0x31a
[    2.182696] [<ffffffff80c36452>] loop_init+0x10c/0x138
[    2.187819] [<ffffffff8000293e>] do_one_initcall+0x5a/0x1e2
[    2.193381] [<ffffffff80c018c2>] kernel_init_freeable+0x28c/0x308
[    2.199460] [<ffffffff80af7e0c>] kernel_init+0x32/0x16e
[    2.204669] [<ffffffff80003ed4>] ret_from_exception+0x0/0x16
[    2.210372] ---[ end trace 0000000000000000 ]---
[    2.214956] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[    2.222572] SMP: stopping secondary CPUs
[    2.226493] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]---