Re: [DMARC error][DKIM error] [PATCH 3/4] arm64: dts: add support for A4 based Amlogic BA400

[Xianwei Zhao]

Hi Krzysztof,
     Thanks for your reply.

On 2024/3/14 14:58, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 14/03/2024 06:19, Xianwei Zhao wrote:
> > > > +
> > > > +             apb@fe000000 {
> > > > +                     compatible = "simple-bus";
> > > > +                     reg = <0x0 0xfe000000 0x0 0x480000>;
> > > > +                     #address-cells = <2>;
> > > > +                     #size-cells = <2>;
> > > > +                     ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
> > > > +
> > > > +                     uart_b: serial@7a000 {
> > > > +                             compatible = "amlogic,meson-s4-uart",
> > >
> > > If I'm not wrong, you need to create dt-binding alias for meson-a4-uart
> > > and use it as 3rd compatible string.
> > On UART module, A4 and A5 SoCs exactly the same as S4. There's no
> > difference.
>
> That's not really the point. You are supposed to always provide SoC
> specific compatible in front of the fallback. See writing bindings document.
Will add bindings.
If two chips use a common dtsi, and this module is in the common dtsi, 
can I only add one to suit this two chips?
> Best regards,
> Krzysztof