Re: [PATCH 1/3] dt-bindings: clock: qcom: Update SM8150 videocc bindings

[Satya Priya Kakitapalli (Temp)]

On 3/14/2024 12:50 AM, Dmitry Baryshkov wrote:
> On Wed, 13 Mar 2024 at 13:11, Satya Priya Kakitapalli
> <quic_skakitap@xxxxxxxxxxx> wrote:
> > Update the videocc device tree bindings for sm8150 to align with the
> > latest convention.
> But why? Bindings already exist. There is nothing wrong with them. And
> sm8150 platform in general uses name-based lookup.


With the new index based lookup introduced we cannot use this bindings, 
hence I moved to the sm8450-videocc bindings.


> > Fixes: 35d26e9292e2 ("dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings")
> It is not a fix, there is no bug that this commit is fixing.


The clocks list needs to be fixed to add both XO and AHB clocks, and we 
are adding required-opps property.


> > Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 1 +
> >   Documentation/devicetree/bindings/clock/qcom,videocc.yaml        | 3 ---
> >   2 files changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> > index bad8f019a8d3..e00fdc8ceaa4 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> > @@ -20,6 +20,7 @@ properties:
> >       enum:
> >         - qcom,sm8450-videocc
> >         - qcom,sm8550-videocc
> > +      - qcom,sm8150-videocc
> >
> >     reg:
> >       maxItems: 1
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> > index 6999e36ace1b..28d134ad9517 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> > @@ -17,7 +17,6 @@ description: |
> >       include/dt-bindings/clock/qcom,videocc-sc7180.h
> >       include/dt-bindings/clock/qcom,videocc-sc7280.h
> >       include/dt-bindings/clock/qcom,videocc-sdm845.h
> > -    include/dt-bindings/clock/qcom,videocc-sm8150.h
> >       include/dt-bindings/clock/qcom,videocc-sm8250.h
> >
> >   properties:
> > @@ -26,7 +25,6 @@ properties:
> >         - qcom,sc7180-videocc
> >         - qcom,sc7280-videocc
> >         - qcom,sdm845-videocc
> > -      - qcom,sm8150-videocc
> >         - qcom,sm8250-videocc
> >
> >     clocks:
> > @@ -75,7 +73,6 @@ allOf:
> >             enum:
> >               - qcom,sc7180-videocc
> >               - qcom,sdm845-videocc
> > -            - qcom,sm8150-videocc
> >       then:
> >         properties:
> >           clocks:
> >
> > --
> > 2.25.1