RE: [EXTERNAL] [PATCH net-next 2/2] vxlan: Remove generic .ndo_get_stats64

From: Subbaraya Sundeep Bhatta
Date: Mon Mar 11 2024 - 07:36:53 EST




>-----Original Message-----
>From: Breno Leitao <leitao@xxxxxxxxxx>
>Sent: Monday, March 11, 2024 4:55 PM
>To: David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
><edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni
><pabeni@xxxxxxxxxx>
>Cc: keescook@xxxxxxxxxxxx; Ido Schimmel <idosch@xxxxxxxxxx>; Nikolay
>Aleksandrov <razor@xxxxxxxxxxxxx>; Amit Cohen <amcohen@xxxxxxxxxx>; Petr
>Machata <petrm@xxxxxxxxxx>; Jiri Benc <jbenc@xxxxxxxxxx>; Beniamino
>Galvani <b.galvani@xxxxxxxxx>; Gavin Li <gavinl@xxxxxxxxxx>; open
>list:NETWORKING DRIVERS <netdev@xxxxxxxxxxxxxxx>; open list <linux-
>kernel@xxxxxxxxxxxxxxx>
>Subject: [EXTERNAL] [PATCH net-next 2/2] vxlan: Remove generic
>.ndo_get_stats64
>
>Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
>configured") moved the callback to dev_get_tstats64() to net core, so,
>unless the driver is doing some custom stats collection, it does not
>need to set .ndo_get_stats64.
>
>Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
>doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
>function pointer.
>
>Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>

Reviewed-by: Subbaraya Sundeep <sbhatta@xxxxxxxxxxx>
..