RE: [EXTERNAL] [PATCH net-next 1/2] vxlan: Do not alloc tstats manually

From: Subbaraya Sundeep Bhatta
Date: Mon Mar 11 2024 - 07:34:49 EST




>-----Original Message-----
>From: Breno Leitao <leitao@xxxxxxxxxx>
>Sent: Monday, March 11, 2024 4:55 PM
>To: David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
><edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni
><pabeni@xxxxxxxxxx>
>Cc: keescook@xxxxxxxxxxxx; Ido Schimmel <idosch@xxxxxxxxxx>; Nikolay
>Aleksandrov <razor@xxxxxxxxxxxxx>; Amit Cohen <amcohen@xxxxxxxxxx>; Petr
>Machata <petrm@xxxxxxxxxx>; Jiri Benc <jbenc@xxxxxxxxxx>; Beniamino
>Galvani <b.galvani@xxxxxxxxx>; Gavin Li <gavinl@xxxxxxxxxx>; open
>list:NETWORKING DRIVERS <netdev@xxxxxxxxxxxxxxx>; open list <linux-
>kernel@xxxxxxxxxxxxxxx>
>Subject: [EXTERNAL] [PATCH net-next 1/2] vxlan: Do not alloc tstats manually
>
>With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
>convert veth & vrf"), stats allocation could be done on net core
>instead of in this driver.
>
>With this new approach, the driver doesn't have to bother with error
>handling (allocation failure checking, making sure free happens in the
>right spot, etc). This is core responsibility now.
>
>Remove the allocation in the vxlan driver and leverage the network
>core allocation instead.
>
>Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>

Reviewed-by: Subbaraya Sundeep <sbhatta@xxxxxxxxxxx>

>---