Re: [PATCH] mips: dts: ralink: mt7621: add cell count properties to usb0

[Krzysztof Kozlowski]

On 06/03/2024 21:21, Justin Swartz wrote:
> Add default #address-cells and #size-cells properties to usb0,
> suitable for hubs and devices without explicitly declared
> interface nodes, as:
> 
>   "#address-cells":
>     description: should be 1 for hub nodes with device nodes,
>       should be 2 for device nodes with interface nodes.
>     enum: [1, 2]
> 
>   "#size-cells":
>     const: 0
> 
> -- from Documentation/devicetree/bindings/usb/usb-device.yaml
> 
> Signed-off-by: Justin Swartz <justin.swartz@xxxxxxxxxxxxxxxx>
> ---
>  arch/mips/boot/dts/ralink/mt7621.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> index 2069249c8..f02965db1 100644
> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> @@ -309,6 +309,9 @@ usb: usb@1e1c0000 {
>  
>  		interrupt-parent = <&gic>;
>  		interrupts = <GIC_SHARED 22 IRQ_TYPE_LEVEL_HIGH>;
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;

Doesn't this bring new W=1 warnings?

Best regards,
Krzysztof