Re: [PATCH v4 3/3] hwmon: Driver for Nuvoton NCT7363Y

[Ban Feng]

Hi Zev,

On Tue, Mar 5, 2024 at 8:28 AM Zev Weiss <zev@xxxxxxxxxxxxxxxxx> wrote:
>
> On Sat, Mar 02, 2024 at 12:19:07AM PST, Zev Weiss wrote:
> >On Mon, Feb 26, 2024 at 04:56:06PM PST, baneric926@xxxxxxxxx wrote:
>
> <snip>
>
> >
> >>+
> >>+     fanin_cnt = of_property_count_u8_elems(child, "tach-ch");
> >>+     if (fanin_cnt < 1)
> >
> >fanin_cnt < 1 || fanin_cnt >= NCT7363_PWM_COUNT
> >
>
> Er, off by one -- just '>' rather than '>=' there I realize now.

ok, fix in v5

Thanks,
Ban

>
>
> Zev
>