Re: [PATCH 3/4] ASoC: fsl: Let imx-audio-rpmsg register platform device for card

From: kernel test robot
Date: Thu Mar 07 2024 - 02:36:12 EST


Hi Chancel,

kernel test robot noticed the following build errors:

[auto build test ERROR on shawnguo/for-next]
[also build test ERROR on broonie-sound/for-next linus/master v6.8-rc7 next-20240306]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Chancel-Liu/ASoC-fsl-imx_pcm_rpmsg-Register-component-with-rpmsg-channel-name/20240306-155945
base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
patch link: https://lore.kernel.org/r/20240306075510.535963-4-chancel.liu%40nxp.com
patch subject: [PATCH 3/4] ASoC: fsl: Let imx-audio-rpmsg register platform device for card
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240307/202403071501.Bo3vcFpu-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240307/202403071501.Bo3vcFpu-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403071501.Bo3vcFpu-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

sound/soc/fsl/imx-audio-rpmsg.c: In function 'imx_audio_rpmsg_probe':
>> sound/soc/fsl/imx-audio-rpmsg.c:107:17: error: label 'fail' used but not defined
107 | goto fail;
| ^~~~


vim +/fail +107 sound/soc/fsl/imx-audio-rpmsg.c

74
75 static int imx_audio_rpmsg_probe(struct rpmsg_device *rpdev)
76 {
77 struct imx_audio_rpmsg *data;
78 int ret = 0;
79
80 dev_info(&rpdev->dev, "new channel: 0x%x -> 0x%x!\n",
81 rpdev->src, rpdev->dst);
82
83 data = devm_kzalloc(&rpdev->dev, sizeof(*data), GFP_KERNEL);
84 if (!data)
85 return -ENOMEM;
86
87 dev_set_drvdata(&rpdev->dev, data);
88
89 /* Register platform driver for rpmsg routine */
90 data->rpmsg_pdev = platform_device_register_data(&rpdev->dev,
91 rpdev->id.name,
92 PLATFORM_DEVID_NONE,
93 NULL, 0);
94 if (IS_ERR(data->rpmsg_pdev)) {
95 dev_err(&rpdev->dev, "failed to register rpmsg platform.\n");
96 ret = PTR_ERR(data->rpmsg_pdev);
97 }
98
99 data->card_pdev = platform_device_register_data(&rpdev->dev,
100 "imx-audio-rpmsg",
101 PLATFORM_DEVID_AUTO,
102 rpdev->id.name,
103 strlen(rpdev->id.name));
104 if (IS_ERR(data->card_pdev)) {
105 dev_err(&rpdev->dev, "failed to register rpmsg card.\n");
106 ret = PTR_ERR(data->card_pdev);
> 107 goto fail;
108 }
109
110 return ret;
111 }
112

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki