Re: [PATCH v1 1/1] x86/rtc: Remove unused intel-mid.h

From: Dave Hansen
Date: Tue Mar 05 2024 - 11:21:42 EST


On 3/5/24 08:10, Andy Shevchenko wrote:
> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,
> this driver doesn't use it, so simply remove the unused header.

Indeed. intel-mid.h provides a pretty small amount of stuff and it's
included in quite a few random-looking spots. There's also gunk that's
only compiled in if CONFIG_X86_INTEL_MID=y so if anyone _did_ somehow
use any of those functions in generic code, they'd probably be creating
compile problems.

Any chance you'd like to look a _bit_ more widely and just clean up all
of the unnecessary intel-mid.h #includes that are scattered around?