Re: [PATCH v2 1/2] dt-bindings: thermal: convert st,stih407-thermal to DT schema

[Rob Herring]

On Fri, Mar 01, 2024 at 06:47:28PM +0100, Raphael Gallais-Pou wrote:
> 'st,passive_colling_temp' does not appear in the device-tree, and 'reg'
> is missing in the device description.
> 
> Convert st,stih407-thermal binding to DT schema format in order to clean
> unused 'st,passive_cooling_temp' and add missing 'reg' property.
> 
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@xxxxxxxxx>
> ---
> Changes in v2:
>   - Change commit log to use imperative
>   - Drop description
>   - Drop 'clocks' description
>   - Add 'reg' property
>   - Add '#thermal-sensor-cells'
>   - Make node name generic in example
>   - Fix YAML style
> ---
>  .../bindings/thermal/st,stih407-thermal.yaml       | 56 ++++++++++++++++++++++
>  .../devicetree/bindings/thermal/st-thermal.txt     | 32 -------------
>  2 files changed, 56 insertions(+), 32 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml b/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml
> new file mode 100644
> index 000000000000..68d7dd8b892f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/st,stih407-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STi digital thermal sensor (DTS)
> +
> +maintainers:
> +  - Patrice Chotard <patrice.chotard@xxxxxxxxxxx>
> +  - Lee Jones <lee@xxxxxxxxxx>
> +
> +allOf:
> +  - $ref: thermal-sensor.yaml
> +
> +properties:
> +  compatible:
> +    const: st,stih407-thermal
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    items:
> +      - const: thermal
> +
> +  interrupts:
> +    description:
> +      For thermal sensors for which no interrupt has been defined, a polling
> +      delay of 1000ms will be used to read the temperature from device.

maxItems: 1

> +
> +  '#thermal-sensor-cells': true

const: 1

Also, not in the original binding, so please state in the commit msg 
why you are adding it.

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    temperature-sensor@91a0000 {
> +        compatible = "st,stih407-thermal";
> +        reg = <0x91a0000 0x28>;
> +        clock-names = "thermal";
> +        clocks = <&CLK_SYSIN>;
> +        interrupts = <GIC_SPI 205 IRQ_TYPE_EDGE_RISING>;
> +        #thermal-sensor-cells = <0>;
> +    };
> +...