Re: [PATCH v1 3/3] PCI: qcom: Add support for detecting controller level PCIe errors

[Krzysztof Kozlowski]

On 21/02/2024 15:04, root wrote:
> From: Nitesh Gupta <nitegupt@xxxxxxxxxxx>
> 
> Synopsys Controllers provide capabilities to detect various controller
> level errors. These can range from controller interface error to random
> PCIe configuration errors. This patch intends to add support to detect
> these errors and report it to userspace entity via sysfs, which can take
> appropriate actions to mitigate the errors.
> 

..

> +
>  static void qcom_pcie_init_debugfs(struct qcom_pcie *pcie)
>  {
>  	struct dw_pcie *pci = pcie->pci;
> @@ -1496,6 +1829,21 @@ static int qcom_pcie_probe(struct platform_device *pdev)
>  		goto err_pm_runtime_put;
>  	}
>  
> +	pcie->global_irq = platform_get_irq_byname(pdev, "global");
> +	if (pcie->global_irq < 0) {
> +		ret = pcie->global_irq;
> +		goto err_pm_runtime_put;

How does this work with old DTS and with all other platforms? Was it tested?

Best regards,
Krzysztof