Re: [PATCH] hexagon: select FRAME_POINTER instead of redefining it

[Randy Dunlap]

On 2/15/24 06:07, Masahiro Yamada wrote:
> Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
> should select it.
> 
> Add 'select FRAME_POINTER' to HEXAGON. ARCH_WANT_FRAME_POINTERS must
> also be selected to avoid the unmet dependency warning.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>

Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> ---
> 
>  arch/hexagon/Kconfig | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> index a880ee067d2e..e922026fef09 100644
> --- a/arch/hexagon/Kconfig
> +++ b/arch/hexagon/Kconfig
> @@ -7,7 +7,9 @@ config HEXAGON
>  	select ARCH_32BIT_OFF_T
>  	select ARCH_HAS_SYNC_DMA_FOR_DEVICE
>  	select ARCH_NO_PREEMPT
> +	select ARCH_WANT_FRAME_POINTERS
>  	select DMA_GLOBAL_POOL
> +	select FRAME_POINTER
>  	# Other pending projects/to-do items.
>  	# select HAVE_REGS_AND_STACK_ACCESS_API
>  	# select HAVE_HW_BREAKPOINT if PERF_EVENTS
> @@ -43,9 +45,6 @@ config HEXAGON_PHYS_OFFSET
>  	help
>  	  Platforms that don't load the kernel at zero set this.
>  
> -config FRAME_POINTER
> -	def_bool y
> -
>  config LOCKDEP_SUPPORT
>  	def_bool y
>  

-- 
#Randy