Re: [PATCH v2 3/5] pwm: dwc: simplify error handling

From: Andy Shevchenko
Date: Mon Feb 12 2024 - 06:52:31 EST


On Fri, Feb 09, 2024 at 10:33:01PM +0200, Raag Jadav wrote:
> On Thu, Feb 08, 2024 at 07:22:13PM +0200, Andy Shevchenko wrote:
> > On Thu, Feb 08, 2024 at 12:35:27PM +0530, Raag Jadav wrote:

..

> > > + return dev_err_probe(dev, ret, "Failed to enable device (%pe)\n", ERR_PTR(ret));
> >
> > Have you checked the output?
> > Note, it will duplicate error codes which we don't want.
>
> True. Does it make sense to remove it?

"...which we don't want." had been stated above :-)

--
With Best Regards,
Andy Shevchenko