Re: [PATCH v2 3/5] pwm: dwc: simplify error handling

From: Raag Jadav
Date: Fri Feb 09 2024 - 15:33:14 EST


On Thu, Feb 08, 2024 at 07:22:13PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 08, 2024 at 12:35:27PM +0530, Raag Jadav wrote:
> > Simplify error handling in ->probe() function using dev_err_probe() helper.
>
> ...
>
> > + return dev_err_probe(dev, ret, "Failed to enable device (%pe)\n", ERR_PTR(ret));
>
> Have you checked the output?
> Note, it will duplicate error codes which we don't want.

True. Does it make sense to remove it?

Raag