Re: [PATCH v4 03/35] include: reduce header dependencies by using "*_types.h"

From: kernel test robot
Date: Sun Feb 11 2024 - 23:16:37 EST


Hi Max,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20240209]
[cannot apply to drm-misc/drm-misc-next media-tree/master mkp-scsi/for-next linus/master v6.8-rc4 v6.8-rc3 v6.8-rc2 v6.8-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Max-Kellermann/include-add-missing-includes/20240212-072756
base: next-20240209
patch link: https://lore.kernel.org/r/20240211231518.349442-4-max.kellermann%40ionos.com
patch subject: [PATCH v4 03/35] include: reduce header dependencies by using "*_types.h"
config: alpha-allnoconfig (https://download.01.org/0day-ci/archive/20240212/202402121235.LLT92dIZ-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240212/202402121235.LLT92dIZ-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402121235.LLT92dIZ-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

In file included from include/linux/flex_proportions.h:11,
from lib/flex_proportions.c:36:
include/linux/percpu_counter.h: In function 'percpu_counter_add':
include/linux/percpu_counter.h:191:9: error: implicit declaration of function 'local_irq_save' [-Werror=implicit-function-declaration]
191 | local_irq_save(flags);
| ^~~~~~~~~~~~~~
include/linux/percpu_counter.h:193:9: error: implicit declaration of function 'local_irq_restore' [-Werror=implicit-function-declaration]
193 | local_irq_restore(flags);
| ^~~~~~~~~~~~~~~~~
>> include/linux/percpu_counter.h:191:9: warning: 'flags' is used uninitialized [-Wuninitialized]
191 | local_irq_save(flags);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/percpu_counter.h:189:23: note: 'flags' was declared here
189 | unsigned long flags;
| ^~~~~
cc1: some warnings being treated as errors


vim +/flags +191 include/linux/percpu_counter.h

80188b0d77d742 Dave Chinner 2015-05-29 185
^1da177e4c3f41 Linus Torvalds 2005-04-16 186 static inline void
20e89767096392 Peter Zijlstra 2007-10-16 187 percpu_counter_add(struct percpu_counter *fbc, s64 amount)
^1da177e4c3f41 Linus Torvalds 2005-04-16 188 {
88ad32a799ddc9 Manfred Spraul 2022-12-16 189 unsigned long flags;
88ad32a799ddc9 Manfred Spraul 2022-12-16 190
88ad32a799ddc9 Manfred Spraul 2022-12-16 @191 local_irq_save(flags);
^1da177e4c3f41 Linus Torvalds 2005-04-16 192 fbc->count += amount;
88ad32a799ddc9 Manfred Spraul 2022-12-16 193 local_irq_restore(flags);
^1da177e4c3f41 Linus Torvalds 2005-04-16 194 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 195

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki