Re: [PATCH v2 1/4] rust: uaccess: add userspace pointers

From: Alice Ryhl
Date: Fri Feb 09 2024 - 06:16:13 EST


On Thu, Feb 8, 2024 at 11:54 PM Valentin Obst <kernel@xxxxxxxxxxxxxxx> wrote:
>
> > + /// Reads the entirety of the user slice, appending it to the end of the
> > + /// provided buffer.
> > + ///
> > + /// Fails with `EFAULT` if the read encounters a page fault.
> > + pub fn read_all(self, buf: &mut Vec<u8>) -> Result<()> {
> > + self.reader().read_all(buf)
> > + }
>
> I think there is also no need to give an explicit `()` for the
> generic type parameter here as it is the default (applies to some
> other methods in this patch as well).

I'll change this if I send a v3, but I don't think it's that important.

Alice