Re: [PATCH v2 1/4] rust: uaccess: add userspace pointers

From: Valentin Obst
Date: Thu Feb 08 2024 - 17:55:42 EST


> + /// Reads the entirety of the user slice, appending it to the end of the
> + /// provided buffer.
> + ///
> + /// Fails with `EFAULT` if the read encounters a page fault.
> + pub fn read_all(self, buf: &mut Vec<u8>) -> Result<()> {
> + self.reader().read_all(buf)
> + }

I think there is also no need to give an explicit `()` for the
generic type parameter here as it is the default (applies to some
other methods in this patch as well).