Re: [PATCH] Revert "arm64: dts: qcom: qrb5165-rb5: add the Bluetooth node"

From: Bartosz Golaszewski
Date: Tue Jan 30 2024 - 10:13:08 EST


On Tue, Jan 30, 2024 at 3:27 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 30/01/2024 14:09, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > This reverts commit 71a73864e144aadaa582fe8296ef73fcf3ea7377.
> >
> > The bluetooth module of the QCA6391 should be represented as consuming
> > the power outputs of the PMU and not the regulators that are PMU's
> > inputs. We will be able to model it this way (together with the WLAN
> > module) once the pwrseq subsystem gets upstream with a dedicated driver
> > for the PMU.
> >
> > Thankfully this change has no corresponding DT bindings yet so we can
> > safely revert adding the bluetooth node.
> >
> > Fixes: 71a73864e144 ("arm64: dts: qcom: qrb5165-rb5: add the Bluetooth node")
>
> I don't think that dropping more-or-less correct DTS nodes is a fix. A
> fix could be changing the less-correct DTS into fully-correct DTS.
>

This node was added this merge window, the bindings didn't make it.
It's not used anywhere AFAIK and a better version is coming.

I'm not going to insist but I think it's useless right now.

Bart