Re: [PATCH v5 net-next 09/13] net: phy: marvell-88q2xxx: add cable test support

From: Russell King (Oracle)
Date: Tue Jan 30 2024 - 04:31:35 EST


On Mon, Jan 22, 2024 at 10:28:42PM +0100, Dimitri Fedrau wrote:
> +static int mv88q222x_cable_test_get_status(struct phy_device *phydev,
> + bool *finished)
> +{
> + int ret;
> + u32 dist;
> +
> + ret = phy_read_mmd(phydev, MDIO_MMD_PCS, MDIO_MMD_PCS_MV_TDR_STATUS);
> + if (ret < 0)
> + return ret;
> +
> + *finished = true;
> + /* fault length in meters */
> + dist = ((ret & MDIO_MMD_PCS_MV_TDR_STATUS_DIST_MASK) >>
> + MDIO_MMD_PCS_MV_TDR_STATUS_DIST_SHIFT) * 100;

dist = FIELD_GET(MDIO_MMD_PCS_MV_TDR_STATUS_DIST_MASK, ret) * 100;


--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!