Re: [PATCH 5/5] clk: samsung: gs101: don't mark non-essential clocks as critical

From: André Draszik
Date: Tue Jan 30 2024 - 04:31:35 EST


On Mon, 2024-01-29 at 13:16 -0600, Sam Protsenko wrote:
> That sounds reasonable. But I wonder if that bit (about making this
> clock CLK_IS_CRITICAL to make earlycon functional) can be documented
> somewhere. Perhaps in the serial driver (earlycon function), or
> somewhere in device tree bindings? Because otherwise it might remain
> an arcane knowledge and people won't be able to use earlycon later.
> Anyways, for this patch:
>
> Reviewed-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
>
> and if you think it makes sense to document the bit above, please do.

Will do on top of
https://lore.kernel.org/all/20240119104526.1221243-6-tudor.ambarus@xxxxxxxxxx/
once that is in.

Cheers,
Andre'