Re: [PATCH 1/2] dt-bindings: usb: mt6360-tcpc: Rename IRQ to PD-IRQB

From: Rob Herring
Date: Fri Jan 12 2024 - 09:20:35 EST


On Fri, Jan 12, 2024 at 10:45:37AM +0100, AngeloGioacchino Del Regno wrote:
> Since there is no user yet, rename the only interrupt of this device
> to "PD-IRQB", avoiding underscores.

It is primarily node and property names that have this recommendation,
not so much -names values.

If there is only 1 interrupt, I'd just drop the name.

> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> index 053264e60583..0bea23ce2f09 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> @@ -24,7 +24,7 @@ properties:
>
> interrupt-names:
> items:
> - - const: PD_IRQB
> + - const: PD-IRQB
>
> connector:
> type: object
> @@ -58,7 +58,7 @@ examples:
> tcpc {
> compatible = "mediatek,mt6360-tcpc";
> interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>;
> - interrupt-names = "PD_IRQB";
> + interrupt-names = "PD-IRQB";
>
> connector {
> compatible = "usb-c-connector";
> --
> 2.43.0
>