Re: [RESEND PATCH v2] acpi: Use access_width over register_width for system memory accesses

From: Jarred White
Date: Fri Jan 12 2024 - 09:19:43 EST


On 12/22/2023 4:00 PM, Easwar Hariharan wrote:
>> @@ -784,7 +792,8 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr)
>>                                                          goto out_free;
>>                                          }
>>
>> -                                       addr = ioremap(gas_t->address, gas_t->bit_width/8);
>> +                                       access_width = ACCESS_WIDTH_TO_BITS(gas_t) / 8;
>
> What would happen if the platform firmware incorrectly provided
> reg->access_witdh == 0?
>


Unfortunately, we have no hardware platform with this configuration to test with. What is the level of concern here? Were there previous changes that raised this similar concerns?


Thanks,
Jarred