Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

From: Eric Snowberg
Date: Tue Jan 02 2024 - 12:34:52 EST




> On Dec 26, 2023, at 9:41 PM, Coiby Xu <coxu@xxxxxxxxxx> wrote:
>
> Currently when the kernel fails to add a cert to the .machine keyring,
> it will throw an error immediately in the function integrity_add_key.
>
> Since the kernel will try adding to the .platform keyring next or throw
> an error (in the caller of integrity_add_key i.e. add_to_machine_keyring),
> so there is no need to throw an error immediately in integrity_add_key.
>
> Reported-by: itrymybest80@xxxxxxxxxxxxxx
> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2239331
> Signed-off-by: Coiby Xu <coxu@xxxxxxxxxx>

Reviewed-by: Eric Snowberg <eric.snowberg@xxxxxxxxxx>