Re: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml

[Krzysztof Kozlowski]

On 27/12/2023 08:07, Ding, Shenghao wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> Sent: Friday, December 22, 2023 1:31 AM
>> To: Ding, Shenghao <shenghao-ding@xxxxxx>; broonie@xxxxxxxxxx;
>> conor+dt@xxxxxxxxxx
>> Cc: robh+dt@xxxxxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx; Lu, Kevin
>> <kevin-lu@xxxxxx>; Xu, Baojun <baojun.xu@xxxxxx>;
>> devicetree@xxxxxxxxxxxxxxx; lgirdwood@xxxxxxxxx; perex@xxxxxxxx; pierre-
>> louis.bossart@xxxxxxxxxxxxxxx; 13916275206@xxxxxxx; linux-
>> sound@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>> liam.r.girdwood@xxxxxxxxx; soyer@xxxxxx; tiwai@xxxxxxx; Gupta, Peeyush
>> <peeyush@xxxxxx>; Navada Kanyana, Mukund <navada@xxxxxx>
>> Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563
>> from yaml
>>
>> On 21/12/2023 11:13, Shenghao Ding wrote:
>>> Remove tas2563 from tas2562, it will be supported in tas2781 to better
>>> support dsp mode.
>>
>> Please provide rationale in terms of bindings and hardware, not in terms of
>> driver. Or at least not only. For example "supported in tas2781" does not fit
>> hardware part, so you sure must be talking about drivers thus why driver
>> change would affect bindings?
> This patch mainly change the binding, not the driver code. Tas2563 is unbound 
> to tas2562 driver, and bound to tas2781 driver.

Then why do you reference driver "tas2781" here?

Best regards,
Krzysztof