Re: [PATCH 0/3] watchdog: sbsa_gwdt: add support for Marvell ac5

From: Rob Herring
Date: Fri Dec 15 2023 - 12:51:04 EST


On Thu, Dec 14, 2023 at 05:04:11PM +0200, Elad Nachman wrote:
> From: Elad Nachman <enachman@xxxxxxxxxxx>
>
> Add support for Marvell ac5/x variant of the ARM
> sbsa global watchdog. This watchdog deviates from
> the standard driver by the following items:
>
> 1. Registers reside in secure register section.
> hence access is only possible via SMC calls to ATF.

Oops.

> 2. There are couple more registers which reside in
> other register areas, which needs to be configured
> in order for the watchdog to properly generate
> reset through the SOC.

Your firmware should configure these.

>
> The new Marvell compatibility string differentiates between
> the original sbsa mode of operation and the Marvell mode of
> operation.
>
>
> Elad Nachman (3):
> dt-bindings: watchdog: add Marvell AC5 watchdog
> arm64: dts: ac5: add watchdog nodes
> watchdog: sbsa_gwdt: add support for Marvell ac5
>
> .../bindings/watchdog/arm,sbsa-gwdt.yaml | 52 +++-
> arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi | 14 +
> arch/arm64/boot/dts/marvell/ac5-98dx35xx.dtsi | 8 +
> drivers/watchdog/sbsa_gwdt.c | 247 ++++++++++++++++--
> 4 files changed, 298 insertions(+), 23 deletions(-)
>
> --
> 2.25.1
>