Re: [net-next PATCH v6 3/3] net: phy: add support for PHY package MMD read/write

[Christian Marangi]

On Wed, Dec 13, 2023 at 04:13:28PM +0000, Russell King (Oracle) wrote:
> On Wed, Dec 13, 2023 at 04:55:08PM +0100, Christian Marangi wrote:
> > On Wed, Dec 13, 2023 at 03:47:19PM +0000, Russell King (Oracle) wrote:
> > > On Wed, Dec 13, 2023 at 11:57:30AM +0100, Christian Marangi wrote:
> > > > Some PHY in PHY package may require to read/write MMD regs to correctly
> > > > configure the PHY package.
> > > > 
> > > > Add support for these additional required function in both lock and no
> > > > lock variant.
> > > > 
> > > > It's assumed that the entire PHY package is either C22 or C45. We use
> > > > C22 or C45 way of writing/reading to mmd regs based on the passed phydev
> > > > whether it's C22 or C45.
> > > > 
> > > > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> > > 
> > > I don't recall what has been said in previous postings of this, but
> > > introducing new helpers without an example user is normally frowned
> > > upon. The lack of cover message for this three patch series also
> > > doesn't help (the cover message could explain why there's no users
> > > being proposed with this addition of helpers.)
> > >
> > 
> > These are prereq for the qca803x PHY driver and the PHY package series.
> > 
> > I can move this single patch in those series, but it was suggested to
> > move these simple change to a separate patch to lower the patch number
> > since they were orthogonal to the PHY package series proposal.
> 
> ... so adding a cover message (your series in general seem to lack
> those) would be a good idea to explain that.
>

I tend to use cover letters only for big series, sorry for not being
very clear about this. Soo should I detach this from here or it O.K.?

-- 
	Ansuel