Re: [PATCH] lib: kstrtox: fix typo in comment

From: Randy Dunlap
Date: Wed Nov 29 2023 - 00:40:20 EST




On 11/28/23 20:48, Wilken Gottwalt wrote:
> On Tue, 28 Nov 2023 08:26:03 -0800
> Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
>> On 11/28/23 00:27, Wilken Gottwalt wrote:
>>> Delete one of the double f's in "iff".
>>>
>>> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@xxxxxxxxxx>
>>
>> Nope, see:
>> https://en.wikipedia.org/wiki/If_and_only_if
>
> Oh, interesting. Never thought of this. Though, now I wonder: How often do such
> "fixes" happen?

I think that I have seen 2 other patches for "iff", but I probably have missed some.



>>> ---
>>> lib/kstrtox.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/kstrtox.c b/lib/kstrtox.c
>>> index d586e6af5e5a..b0a9fdce15b3 100644
>>> --- a/lib/kstrtox.c
>>> +++ b/lib/kstrtox.c
>>> @@ -340,7 +340,7 @@ EXPORT_SYMBOL(kstrtos8);
>>> * @s: input string
>>> * @res: result
>>> *
>>> - * This routine returns 0 iff the first character is one of 'YyTt1NnFf0', or
>>> + * This routine returns 0 if the first character is one of 'YyTt1NnFf0', or
>>> * [oO][NnFf] for "on" and "off". Otherwise it will return -EINVAL. Value
>>> * pointed to by res is updated upon finding a match.
>>> */
>>
>

--
~Randy