Re: [PATCH] lib: kstrtox: fix typo in comment

From: Wilken Gottwalt
Date: Tue Nov 28 2023 - 23:48:45 EST


On Tue, 28 Nov 2023 08:26:03 -0800
Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

> On 11/28/23 00:27, Wilken Gottwalt wrote:
> > Delete one of the double f's in "iff".
> >
> > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@xxxxxxxxxx>
>
> Nope, see:
> https://en.wikipedia.org/wiki/If_and_only_if

Oh, interesting. Never thought of this. Though, now I wonder: How often do such
"fixes" happen?

> > ---
> > lib/kstrtox.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/kstrtox.c b/lib/kstrtox.c
> > index d586e6af5e5a..b0a9fdce15b3 100644
> > --- a/lib/kstrtox.c
> > +++ b/lib/kstrtox.c
> > @@ -340,7 +340,7 @@ EXPORT_SYMBOL(kstrtos8);
> > * @s: input string
> > * @res: result
> > *
> > - * This routine returns 0 iff the first character is one of 'YyTt1NnFf0', or
> > + * This routine returns 0 if the first character is one of 'YyTt1NnFf0', or
> > * [oO][NnFf] for "on" and "off". Otherwise it will return -EINVAL. Value
> > * pointed to by res is updated upon finding a match.
> > */
>