RE: [PATCH v3 1/2] dt-bindings: iio: frequency: add admfm2000

From: Paller, Kim Seer
Date: Thu Nov 23 2023 - 01:14:22 EST


> > ---
> > V2 -> V3: Adjusted indentation to resolve wrong indentation warning.
> > Changed node name to converter. Updated the descriptions to clarify
> > the properties.
>
>
> > +title: ADMFM2000 Dual Microwave Down Converter
> > +
> > +maintainers:
> > + - Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> > +
> > +description:
> > + Dual microwave down converter module with input RF and LO frequency
> ranges
> > + from 0.5 to 32 GHz and an output IF frequency range from 0.1 to 8 GHz.
> > + It consists of a LNA, mixer, IF filter, DSA, and IF amplifier for each down
> > + conversion path.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - adi,admfm2000
> > +
> > + switch1-gpios:
> > + items:
> > + - description:
> > + Setting B15 GPIO to high and B16 GPIO to low will result in channel 1
> > + being in Direct IF mode.
> > + - description:
> > + Setting B15 GPIO to low and B16 GPIO to high will result in channel 1
> > + being in Mixer mode.
>
> This still does not tell which one is B15 and which is B16. I am asking
> this for third time.
>
> items:
> - description: B15 GPIO, when high (and B16 low) channel 1 is in
> Direct IF mode

I understand now, thank you. I was also wondering if this applies to the
attenuation-gpios, or if I should keep it as is?

Best regards,
Kim