Re: [PATCH 2/2] zstd: Backport Huffman speed improvement from upstream

[Nick Terrell]

> On Nov 21, 2023, at 3:12 PM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> !-------------------------------------------------------------------|
>  This Message Is From an External Sender
> 
> |-------------------------------------------------------------------!
> 
> On Tue, 21 Nov 2023 at 11:59, Nick Terrell <terrelln@xxxxxxxx> wrote:
>> 
>> W.r.t. do { } while (0), our older Visual Studios CI jobs failed on the
>> do { } while (0) macros, because it complained about constant false
>> branches.
> 
> Wow. That is some truly incompetent compiler people.
> 
> I mean, really. As in "Why would you ever use that kind of garbage"
> incompetence.
> 
> Honestly, any coding rule that includes "don't use the do-while-zero
> construct" is actively broken shit.
> 
> Please just fix your upstream rules. Because they are incredible garbage.

Yeah, that’s the plan. Visual Studios fixed that compiler bug in VS2015 [0],
so we should be safe to migrate to safer macros. I’m going through and
doing that now, and will backport that to the kernel on top of this series.

[0] https://stackoverflow.com/a/36658783

>               Linus