Re: [PATCH 2/2] zstd: Backport Huffman speed improvement from upstream

From: Linus Torvalds
Date: Tue Nov 21 2023 - 15:13:12 EST


On Tue, 21 Nov 2023 at 11:59, Nick Terrell <terrelln@xxxxxxxx> wrote:
>
> W.r.t. do { } while (0), our older Visual Studios CI jobs failed on the
> do { } while (0) macros, because it complained about constant false
> branches.

Wow. That is some truly incompetent compiler people.

I mean, really. As in "Why would you ever use that kind of garbage"
incompetence.

Honestly, any coding rule that includes "don't use the do-while-zero
construct" is actively broken shit.

Please just fix your upstream rules. Because they are incredible garbage.

Linus